public void visit(Relation r) {
nonClosedWays.clear();
if (r.isMultipolygon()) {
checkMembersAndRoles(r);
Multipolygon polygon = MultipolygonCache.getInstance().get(Main.map.mapView, r);
boolean hasOuterWay = false;
for (RelationMember m : r.getMembers()) {
if ("outer".equals(m.getRole())) {
hasOuterWay = true;
break;
}
}
if (!hasOuterWay) {
addError(r, new TestError(this, Severity.WARNING, tr("No outer way for multipolygon"), MISSING_OUTER_WAY, r));
}
if (r.hasIncompleteMembers()) {
return; // Rest of checks is only for complete multipolygons
}
// Create new multipolygon using the logics from CreateMultipolygonAction and see if roles match.
final Pair<Relation, Relation> newMP = CreateMultipolygonAction.createMultipolygonRelation(r.getMemberPrimitives(Way.class), false);
if (newMP != null) {
for (RelationMember member : r.getMembers()) {
final Collection<RelationMember> memberInNewMP = newMP.b.getMembersFor(Collections.singleton(member.getMember()));
if (memberInNewMP != null && !memberInNewMP.isEmpty()) {
final String roleInNewMP = memberInNewMP.iterator().next().getRole();
if (!member.getRole().equals(roleInNewMP)) {
addError(r, new TestError(this, Severity.WARNING, RelationChecker.ROLE_VERIF_PROBLEM_MSG,
tr("Role for ''{0}'' should be ''{1}''",
member.getMember().getDisplayName(DefaultNameFormatter.getInstance()), roleInNewMP),
MessageFormat.format("Role for ''{0}'' should be ''{1}''",
member.getMember().getDisplayName(DefaultNameFormatter.getInstance()), roleInNewMP),
WRONG_MEMBER_ROLE, Collections.singleton(r), Collections.singleton(member.getMember())));
}
}
}
}
List<List<Node>> innerWays = joinWays(polygon.getInnerWays()); // Side effect - sets nonClosedWays
List<List<Node>> outerWays = joinWays(polygon.getOuterWays());
if (styles != null) {
AreaElemStyle area = ElemStyles.getAreaElemStyle(r, false);
boolean areaStyle = area != null;
// If area style was not found for relation then use style of ways
if (area == null) {
for (Way w : polygon.getOuterWays()) {
area = ElemStyles.getAreaElemStyle(w, true);
if (area != null) {
break;
}
}
if (!"boundary".equals(r.get("type"))) {
if (area == null) {
addError(r, new TestError(this, Severity.OTHER, tr("No style for multipolygon"), NO_STYLE, r));
} else {
addError(r, new TestError(this, Severity.OTHER, tr("No style in multipolygon relation"),
NO_STYLE_POLYGON, r));
}
}
}
if (area != null) {
for (Way wInner : polygon.getInnerWays()) {
AreaElemStyle areaInner = ElemStyles.getAreaElemStyle(wInner, false);
if (areaInner != null && area.equals(areaInner)) {
List<OsmPrimitive> l = new ArrayList<>();
l.add(r);
l.add(wInner);
addError(r, new TestError(this, Severity.WARNING, tr("Style for inner way equals multipolygon"),
INNER_STYLE_MISMATCH, l, Collections.singletonList(wInner)));
}
}
if(!areaStyle) {
for (Way wOuter : polygon.getOuterWays()) {
AreaElemStyle areaOuter = ElemStyles.getAreaElemStyle(wOuter, false);
if (areaOuter != null && !area.equals(areaOuter)) {
List<OsmPrimitive> l = new ArrayList<>();
l.add(r);
l.add(wOuter);